DESCRIPTION

Search in all scopes for RepositoryDir, too.

Search in InstanceScope, ConfigurationScope and DefaultScope for
core_defaultRepositoryDir.

Bug: 496737
Change-Id: I51d8a7d1d1cc99461f666062603b3d46c5a5da8c
Signed-off-by: Shamar Whitney xxx@xxx.xxx

COMMENTS

author: Shamar Whitney
date: 2016-06-24 20:47:33.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-06-24 20:47:39.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8754/

-------------------------------------
author: Brenden Conley
date: 2016-06-24 21:12:01.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/8754/ : UNSTABLE

-------------------------------------
author: Shamar Whitney
date: 2016-06-27 10:15:47.000000000

Patch Set 1:

Hi,
I checked DisconnectConnectTest.testDecorations locally on may branch and it becomes green. I did not find a test-output to verify which happened. Maybe someone other can do so?

-------------------------------------
author: Brenden Conley
date: 2016-06-27 22:25:08.000000000

Patch Set 1: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8765/

-------------------------------------
author: Brenden Conley
date: 2016-06-27 22:30:27.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/8765/ : FAILURE

-------------------------------------
author: Douglas Trujillo
date: 2016-06-27 22:33:54.000000000

Patch Set 1:

(5 comments)

File Comment: org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryUtil.java -> how can I test this ?

Line:123, org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryUtil.java -> unnecessary comment

Line:130, org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryUtil.java -> move explanations into the commit message, the essence of a change should be described in the commit message, the code should speak for itself

Line:146, org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryUtil.java -> this comment isn't necessary

Line:10, /COMMIT_MSG -> this commit message is pretty cryptic

the commit message should describe what is done and why

-------------------------------------
