DESCRIPTION

Git Repositories View: Refactoring first part

The Git Repositories View should be refactored to use
the Object Contribution extension point for building
the context menus instead of doing this programmatically
in the View class itself.
This is the first part of this refractoring. It does not
refactor the menu contribution yet, just makes makes the previous
tree node class abstract and creates a new concrete subclass
for each tree node type in order to being able to use those
classes in the extension.

COMMENTS

author: Malia Sampson
date: 2010-05-25 13:57:50.000000000

Patch Set 1: No score; IP review completed

I agree, I like the direction this is going.

However note, in the future, we want to use the org.eclipse.ui.menus extension point for everything when we support Eclipse 3.5-3.7 when we start shipping 0.9.0 :)

-------------------------------------
author: Douglas Trujillo
date: 2010-05-25 14:46:40.000000000

Patch Set 1: I would prefer that you didn't submit this; No score

yeah, direction looks good

the new classes have no license header

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/LocalBranchesNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/SymbolicRefsNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RepositoryTreeNodeType.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RepositoryNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/TagNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/BranchesNode.java -> license header missing

Line:12, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/BranchesNode.java -> trailing whitespace

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/SymbolicRefNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RemotesNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/PushNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/ErrorNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/FetchNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RemoteBranchesNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/WorkingDirNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/FileNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RemoteNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RefNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/TagsNode.java -> license header missing

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/FolderNode.java -> license header missing

-------------------------------------
