DESCRIPTION

Add tag icon for tags in tag list in CrateTagDialog

Adds tag icon for each tag that is in 'Existing tags' list in
CreateTagDialog.

Change-Id: Ib11cdcc7df976368fa64d6d26a5de339864cb57e
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2010-05-22 18:18:49.000000000

Patch Set 1: I would prefer that you didn't submit this; No score



Line:147, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java -> You are leaking image resources here, I think you should use a ResourceManager to dispose the images when the dialog is closed. For an example have a look at class GitDecoratorPreferencePage

-------------------------------------
author: Leslie Stephenson
date: 2010-05-22 18:56:31.000000000

Patch Set 1: No score



Line:147, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java -> Can I use ImageRegistry instead of ResourceManager ?

It seems that ImageRegistry is easier to use here.

-------------------------------------
