DESCRIPTION

Mark current branch with check symbol in Gitflow feature checkout dialog

This should make the dialog more consistent with other EGit checkout
dialogs.

Change-Id: Iafcf345e3589af903c7a003c8f13df6166b80f3e
Signed-off-by: Jamarion Hunt xxx@xxx.xxx

COMMENTS

author: Jamarion Hunt
date: 2016-04-19 21:18:48.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-04-19 21:18:54.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8407/

-------------------------------------
author: Brenden Conley
date: 2016-04-19 21:50:43.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8407/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-04-21 19:02:35.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:22, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> I would leave the caching to the LocalResourceManager.

Line:25, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> Why not use the resource manager of the egit UI plugin?

  Activator.getDefault().getResourceManager()

Yes, it'll cache things a little too long, but the branch icons are cached there anyway (see SwitchToMenu).

Line:68, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> Since this label provider always returns either the branch icon or the "checked-out branch icon", a general-purpose image decoration functions is probably overkill. Just use
UIIcons.getImage(resourceManager, UIIcons.BRANCH) or UIIcons.getImage(resourceManager, UIIcons.CHECKED_OUT_BRANCH), respectively.

Also has the advantage that you don't have to worry about disposing images.

-------------------------------------
author: Jamarion Hunt
date: 2016-04-26 20:11:39.000000000

Patch Set 1:

(3 comments)

Line:22, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> Done

Line:25, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> Done

Line:68, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/dialogs/DecoratedBranchLabelProvider.java -> Done

I have had some ideas about adding decorators for outdated feature branches, etc., but it makes sense to keep it simple until then.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-05-15 23:01:47.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
