DESCRIPTION

Fixed repository search dialog to detect .git files under selected root.

The search did not detected working tree with .git file in selected root
folder. It always looked in sub-folders only and in case of .git folders
it worked fine. Now it checks the selected root folder additionally to
it's children. The Git private folders like .git folder itself are not
traversed anymore.

This prepares EGit to still properly detect git repositories when
JGit change "https://git.eclipse.org/r/#/c/67873/" adds the evaluation
of ".git" file with "gitdir" link to worktree and evaluates commondir.

Bug: 477475
Change-Id: I9282c3431ca9946159f389168e4ad322ab42838c
Signed-off-by: Genevieve Hudson xxx@xxx.xxx


COMMENTS

author: Genevieve Hudson
date: 2016-03-21 21:00:15.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2016-03-21 21:00:21.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8328/

-------------------------------------
author: Brenden Conley
date: 2016-03-21 21:29:38.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/8328/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2016-03-21 21:30:17.000000000

Patch Set 4: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8329/

-------------------------------------
author: Brenden Conley
date: 2016-03-21 21:57:27.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/8329/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2016-03-21 22:41:46.000000000

Patch Set 4: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8330/

-------------------------------------
author: Douglas Trujillo
date: 2016-03-21 23:12:17.000000000

Patch Set 4: Code-Review-1

(8 comments)

Line:405, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> I think this should better be named gitDirs

Line:424, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> unnecessary null check, according to javadoc File.listFiles() only returns null if the File is not a directory, but if root is not a directory we return from this method already in line 409

Line:432, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> s/of/in/

Line:433, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> this part of the comment seems unnecessary

Line:7, /COMMIT_MSG -> s/Fixed/Fix/

Line:9, /COMMIT_MSG -> s/detected/detect/

Line:11, /COMMIT_MSG -> s/Now it checks/Now it also checks/

Line:12, /COMMIT_MSG -> s/it's/its/

-------------------------------------
author: Brenden Conley
date: 2016-03-21 23:31:56.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/8330/ : ABORTED

-------------------------------------
author: Genevieve Hudson
date: 2016-03-22 06:04:38.000000000

Patch Set 4: Code-Review+1

(8 comments)

Thanks, see next PS

Line:405, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Agreed, strings -> gitDirs

Line:424, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Yes, it returns empty list here and null check is not needed.

Line:432, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:433, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:7, /COMMIT_MSG -> Done

Line:9, /COMMIT_MSG -> Done

Line:11, /COMMIT_MSG -> Done

Line:12, /COMMIT_MSG -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-03-22 10:41:20.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
