DESCRIPTION

[staging view] Fixed sort order: added check for "names first" case

Bug: 487004
Change-Id: I59b0c32c8c077111ebc2e61026961332933e8b54


COMMENTS

author: Jayvion Booth
date: 2016-02-26 15:38:52.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-02-26 15:38:58.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8199/

-------------------------------------
author: Brenden Conley
date: 2016-02-26 16:07:24.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8199/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-02-26 19:27:29.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:1688, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> This needs to be done *before* calling refreshViewersPreservingExpandedElements(). Otherwise the new setting for the comparator is not yet effective during the refresh, which gives very strange behavior.

-------------------------------------
author: Jayvion Booth
date: 2016-02-26 19:29:39.000000000

Patch Set 1:

Thomas, if you have the patch in the IDE right now, can you update and push? Thanks for reviewing!

-------------------------------------
author: Alayna Houston
date: 2016-02-26 19:36:55.000000000

Patch Set 1:

(1 comment)

Line:1688, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-02-28 00:37:13.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
