DESCRIPTION

Fixed enablement of Gitflow command for creating release from commit

Enable the "Start release from...", available in the History views
Gitflow submenu, only if the currently selected commit is on the develop
branch.

http://nvie.com/posts/a-successful-git-branching-model/#release-branches

Change-Id: I6f0213b2b57f11b9833be979cbf0b3ca98c93f11
Signed-off-by: Jamarion Hunt xxx@xxx.xxx

COMMENTS

author: Jamarion Hunt
date: 2016-02-07 22:17:58.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-02-07 22:18:04.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8103/

-------------------------------------
author: Jamarion Hunt
date: 2016-02-07 22:18:45.000000000

Patch Set 1:

Also see discussion in 63917.

-------------------------------------
author: Brenden Conley
date: 2016-02-07 22:42:35.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8103/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-02-08 06:05:14.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:317, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowRepository.java -> Naming: this (private) method has a general interface; it's not limited to the develop branch. Hence this should be named more generally. Perhaps just "ref"?

Also add

  if (ref == null) {
    return false;
  }

to avoid calculating the branch list if there is no branch with the given name.

Line:323, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowRepository.java -> Wrap as IOException, not RuntimeException.

-------------------------------------
author: Jamarion Hunt
date: 2016-02-08 18:47:01.000000000

Patch Set 1:

(2 comments)

Line:317, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowRepository.java -> Done

Line:323, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowRepository.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-02-09 08:32:44.000000000

Change has been successfully merged into the git repository by Jamarion Hunt

-------------------------------------
