DESCRIPTION

[sync] Restore configured synchronization after eclipse exit

Now synchronization configuration is persisted between eclipse sessions.
Users can also "pin" configured synchronization.

Bug: 354829
Change-Id: I2f24b557e77e6ed155f206056ca1a24d4827ecd1
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2012-08-15 10:39:09.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2012-08-15 10:39:15.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3251/ 

-------------------------------------
author: Leslie Stephenson
date: 2012-08-15 10:43:29.000000000

Patch Set 6:

Fixed restoring pined Git Commit Model

-------------------------------------
author: Brenden Conley
date: 2012-08-15 10:45:29.000000000

Patch Set 6: Fails

Build Failed 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3251/ : FAILURE

-------------------------------------
author: Cooper Durham
date: 2012-08-16 08:54:00.000000000

Patch Set 6:

Seem better with patch set 6.
All is restored correctly.

-------------------------------------
author: Danika Greer
date: 2012-08-16 10:34:29.000000000

Patch Set 6: Verified; Looks good to me, but someone else must approve; IP review completed

Looks good now!

-------------------------------------
author: Brenden Conley
date: 2012-08-16 23:17:33.000000000

Patch Set 6: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3264/ 

-------------------------------------
author: Brenden Conley
date: 2012-08-16 23:30:51.000000000

Patch Set 6: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3264/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2012-09-01 13:15:00.000000000

Patch Set 6: (3 inline comments)



Line:234, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java -> It is ok that the order of the included paths could change (because it is a HashSet)? Maybe it should be a LinkedHashSet to get stable ordering.

Line:360, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java -> If the above comment is addressed, this should also be a LinkedHashSet.

Line:1609, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Typo: ScpeName -> ScopeName

-------------------------------------
author: Leslie Stephenson
date: 2012-09-05 15:21:38.000000000

Patch Set 6: (1 inline comment)



Line:234, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java -> to be honest I can't imagine any real side effects for having included paths unordered. at the end everything is sorted alphabetically in view. IMO also changing order of filtered paths shouldn't change synchronization results.

-------------------------------------
author: Douglas Trujillo
date: 2012-09-05 15:27:03.000000000

Patch Set 6: (1 inline comment)



Line:1609, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

-------------------------------------
