DESCRIPTION

[sync] Restore configured synchronization after eclipse exit

Now synchronization configuration is persisted between eclipse sessions.
Users can also "pin" configured synchronization.

Bug: 354829
Change-Id: I2f24b557e77e6ed155f206056ca1a24d4827ecd1
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2012-08-05 20:29:38.000000000

Uploaded patch set 4.

-------------------------------------
author: Leslie Stephenson
date: 2012-08-05 20:32:08.000000000

Patch Set 4:

fixed NPE and rebased on current master

-------------------------------------
author: Danika Greer
date: 2012-08-08 16:53:05.000000000

Patch Set 4:

I get this NPE after restarting and clicking on Synchronize, is this related to this change?:

Thread [Worker-1] (Suspended (exception java.lang.NullPointerException))	
	org.eclipse.egit.core.synchronize.GitResourceVariantTreeSubscriber.refresh(org.eclipse.core.resources.IResource[], int, org.eclipse.core.runtime.IProgressMonitor) line: 184	
	org.eclipse.egit.core.synchronize.GitResourceVariantTreeSubscriber(org.eclipse.team.core.subscribers.Subscriber).refresh(org.eclipse.core.resources.mapping.ResourceTraversal[], org.eclipse.core.runtime.IProgressMonitor) line: 466	
	org.eclipse.egit.core.synchronize.GitSubscriberMergeContext(org.eclipse.team.core.subscribers.SubscriberMergeContext).refresh(org.eclipse.core.resources.mapping.ResourceTraversal[], int, org.eclipse.core.runtime.IProgressMonitor) line: 85	
	org.eclipse.egit.core.synchronize.GitSubscriberMergeContext(org.eclipse.team.core.mapping.provider.SynchronizationContext).refresh(org.eclipse.core.resources.mapping.ResourceMapping[], org.eclipse.core.runtime.IProgressMonitor) line: 109	
	org.eclipse.team.internal.ui.synchronize.RefreshModelParticipantJob.doRefresh(org.eclipse.team.internal.ui.synchronize.RefreshParticipantJob$IChangeDescription, org.eclipse.core.runtime.IProgressMonitor) line: 69	
	org.eclipse.team.internal.ui.synchronize.RefreshModelParticipantJob(org.eclipse.team.internal.ui.synchronize.RefreshParticipantJob).run(org.eclipse.core.runtime.IProgressMonitor) line: 309	
	org.eclipse.team.internal.ui.synchronize.RefreshModelParticipantJob.run(org.eclipse.core.runtime.IProgressMonitor) line: 117	
	org.eclipse.core.internal.jobs.Worker.run() line: 54

-------------------------------------
author: Leslie Stephenson
date: 2012-08-09 17:30:35.000000000

Patch Set 4:

Strange, it looks like GitResourceVariantTreeSubscriber.init(IProgressMonitor) method wasn't call before refresh(). Could you provide scenario how this issue can be reproduced ?

-------------------------------------
author: Danika Greer
date: 2012-08-10 08:14:20.000000000

Patch Set 4:

I did the following IIRC:

# Right click on a project -> Team -> Synchronize Workspace
# Pin synchronization
# Restart Eclipse
# Populate
# Click on Synchronize -> Exception

-------------------------------------
author: Brenden Conley
date: 2012-08-10 12:57:21.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3232/ 

-------------------------------------
author: Brenden Conley
date: 2012-08-10 13:11:23.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3232/ : SUCCESS

-------------------------------------
