DESCRIPTION

Extension point for commit message editor added. Bug 486268

Change-Id: I88cd984b24f029fa0f2954fd1cc9479d2795ab27
Signed-off-by: Shea Love xxx@xxx.xxx


COMMENTS

author: Evelin Sutton
date: 2016-01-26 16:44:55.000000000

Uploaded patch set 1.

-------------------------------------
author: Helena Henry
date: 2016-01-26 16:44:59.000000000

Patch Set 1:

This contribution is over 1000 lines of code and a CQ may be needed[1].
Project committers, please confirm if a CQ is needed by replying to this comment (in Gerrit), leaving the quote intact, and Genie will automagically create a CQ.

[1] https://eclipse.org/legal/EclipseLegalProcessPoster.pdf.
-genie:cq

-------------------------------------
author: Brenden Conley
date: 2016-01-26 16:45:01.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8083/

-------------------------------------
author: Brenden Conley
date: 2016-01-26 17:10:13.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8083/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-01-26 18:33:53.000000000

Patch Set 1: Code-Review-2

(38 comments)

Thanks for the contribution, but I had lot of formal issues with the code. Could you clean it up, so that I could start to test it?

Line:11, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitEditorProvider.java -> Missing asterisk?

Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitEditorProvider.java -> trailing space

File Comment: org.eclipse.egit.ui/schema/commitMessageEditor.exsd -> Seemst that this file is not referenced in plugin.xml but contains partly more data as another one? Which one from two schemes is the final one?

Line:845, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> The new line formatting is manual or by the formatter? Anyway, this looks ugly. Could you please reformat this piece?

Line:25, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/DefaultCommitEditorProvider.java -> Please remove this noise

Line:80, org.eclipse.egit.ui/schema/commitMessage.exsd -> Here and above: could you please either remove the placeholder text or better to fill in something meaningful?

Line:96, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageArea.java -> What is the purpose to override it if it does the same?

Line:188, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:310, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:426, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:453, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:584, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:599, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:619, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:634, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:642, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:758, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:813, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:837, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:857, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:906, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:918, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Please undo white space change

Line:7, /COMMIT_MSG -> We have conventions to put this on the extra line in the form:

Bug: <number>

Line:24, org.eclipse.egit.ui/src/org/eclipse/egit/ui/PreferenceConstants.java -> mylyn? In egit constants?

File Comment: org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageWrapper.java -> Missing license header.

BTW is this written by you or just copied from somewhere in egit? The code style & comments differ from other code you've added.

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageWrapper.java -> ?

File Comment: org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> The interface is added by mistake? There is another one in the different package added.

Line:27, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> can it return null? Please document it.

Line:32, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> can it return null? Please document it.

Line:40, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> can it receive null? Please document it.

Line:43, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> Zombie javadoc

Line:108, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageEditor.java -> ?

File Comment: org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageEditor.java -> This interface seem to be automatically extracted and needs some more love. Could you please properly format it and fill in missing javadocs etc?

Line:46, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageEditor.java -> ?? Javadoc without a method?

Line:113, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageEditor.java -> ?

Line:118, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageEditor.java -> Opening brace goes behind the class name.

Line:7, org.eclipse.egit.ui/plugin.xml -> I don't see the externalized value added to the plugin.properties

Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitEditorProvider.java -> can it be null? Please document the contract. Similar for styles: what they can be etc.

-------------------------------------
author: Jayvion Booth
date: 2016-01-26 18:34:32.000000000

Patch Set 1:

BTW I haven't reviewed the mylyn code, same rules apply there.

-------------------------------------
author: Jayvion Booth
date: 2016-01-26 18:35:29.000000000

Patch Set 1:

I think it would be better to split this into two commits: the one for egit, and another one for mylyn plugin.

-------------------------------------
