DESCRIPTION

[performance] Remove ContainerTreeIterator and AdaptableFileTreeIterator

Don't hook any extra Eclipse based iterators to jgit tree traversal:

1) Eclipse IResource API can't handle "unusual" links (unresolved or
recursive), see bug 290318. This is a major functional deficiency for
repositories which make use of links.

2) The assumption that Eclipse IResource API traverses the file system
faster as java.io does not hold on Windows/Linux/NFS with modern (7+)
Java, see bug 484498 comments 10 and 14, the opposite is true:
especially on Linux the java.io access is times faster as IResource API
or what the ContainerTreeIterator makes of it.

AdaptableFileTreeIterator/ContainerTreeIterator use is replaced with
default FileTreeIterator, tests adopted or removed.

Bug: 484498
Change-Id: I026abee1706e6fbcd470cc7262b9fc1e59a7fe8b
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-12-23 09:18:49.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7983/

-------------------------------------
author: Brenden Conley
date: 2015-12-23 09:45:15.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7983/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-12-23 15:25:52.000000000

Patch Set 4:

On Mac the following tests fail, not sure if this is related

Running org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest
Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 6.371 sec <<< FAILURE! - in org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest
testCleanStateAfterInit(org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest)  Time elapsed: 3.019 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest.testCleanStateAfterInit(SubmoduleAndContainerTreeIteratorTest.java:100)

testCleanStateFirstCommit(org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest)  Time elapsed: 3.349 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest.testCleanStateFirstCommit(SubmoduleAndContainerTreeIteratorTest.java:113)

-------------------------------------
author: Jayvion Booth
date: 2015-12-23 15:37:32.000000000

Patch Set 4:

> On Mac the following tests fail, not sure if this is related
 > 
 > Running org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest
 > Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
 > 6.371 sec <<< FAILURE! - in org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest
 > testCleanStateAfterInit(org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest)
 >  Time elapsed: 3.019 sec  <<< FAILURE!
 > java.lang.AssertionError: null
 > at org.junit.Assert.fail(Assert.java:86)
 > at org.junit.Assert.assertTrue(Assert.java:41)
 > at org.junit.Assert.assertTrue(Assert.java:52)
 > at org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest.testCleanStateAfterInit(SubmoduleAndContainerTreeIteratorTest.java:100)
 > 
 > testCleanStateFirstCommit(org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest)
 >  Time elapsed: 3.349 sec  <<< FAILURE!
 > java.lang.AssertionError: null
 > at org.junit.Assert.fail(Assert.java:86)
 > at org.junit.Assert.assertTrue(Assert.java:41)
 > at org.junit.Assert.assertTrue(Assert.java:52)
 > at org.eclipse.egit.core.test.SubmoduleAndContainerTreeIteratorTest.testCleanStateFirstCommit(SubmoduleAndContainerTreeIteratorTest.java:113)

If this is reproducible, we must have either a bug in code or in the test onMac, related to the repository status computation. Tje patch pronably uncovered it beacuse now we see a *real* file/repository state.

-------------------------------------
author: Douglas Trujillo
date: 2015-12-23 15:42:08.000000000

Patch Set 4:

I can bisect this later today

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-12-23 22:48:28.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
