DESCRIPTION

Improve auto-filling the repository URL from clipboard in clone wizard

So far in the clone wizard we auto-fill the repository URL if the
clipboard contains a valid URL. Enhance this to also accept a valid git
clone command.

Also auto-fill the repository URL for http and https protocols.

Bug: 484412
Change-Id: I6d56e17380e401badafd9b564e8c095d7894bac4
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2015-12-16 13:37:29.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-12-16 13:37:35.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7950/

-------------------------------------
author: Brenden Conley
date: 2015-12-16 13:44:40.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/7950/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2015-12-16 15:04:57.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7952/

-------------------------------------
author: Brenden Conley
date: 2015-12-16 15:15:43.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/7952/ : FAILURE

-------------------------------------
author: Alayna Houston
date: 2015-12-16 16:10:52.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:330, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> That's too early: we may get null here, and stripGitCloneCommand doesn't like being passed null.

Line:333, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> Maybe replacing this with stripGitCloneCommand(text) is better.

-------------------------------------
author: Brenden Conley
date: 2015-12-16 16:14:33.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7956/

-------------------------------------
author: Brenden Conley
date: 2015-12-16 16:21:28.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/7956/ : FAILURE

-------------------------------------
author: Alayna Houston
date: 2015-12-16 18:33:42.000000000

Patch Set 1:

> Build Failed
 > 
 > https://hudson.eclipse.org/egit/job/egit.gerrit/7956/ : FAILURE

Due to exactly the NPE I mentioned on line 329/330. Check https://hudson.eclipse.org/egit/job/egit.gerrit/ws/org.eclipse.egit.ui.importer.tests/target/work/data/.metadata/.log

BTW, that log is full of messages like

  !ENTRY org.eclipse.e4.ui.workbench 4 0 2015-12-16 11:21:10.689
  !MESSAGE Event Admin service is not available, unable to publish event org.osgi.service.event.Event

So... a couple of points:

1. What causes these Event Admin messages?
2. egit.mylyn.ui.test and egit.importer.tests run without -Declipse.consoleLog=true.
3. egit.mylyn.ui.test has quite different tycho-surefire settings.
4. egit.importer.tests lacks the !mac profile, and also neglects to include ${test.vmparams}
5. Why do the mac-os profiles _not_ include the test.vmparams?

Finally, how can we set up tycho or our SWT bot (framework) so that we do get screenshots for failing tests? The SWTBotJunit4ClassRunner can do that. Also, such screenshots would need to be archived as build artifacts.

-------------------------------------
author: Douglas Trujillo
date: 2015-12-16 20:22:06.000000000

Patch Set 1:

(2 comments)

Line:330, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> oops

Line:333, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-12-17 08:18:14.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
