DESCRIPTION

[historyView] Load commit body lazily

The body of loaded objects is now thrown away in the walker after it has
parsed the information necessary to render the history graph. It is
reloaded when content of the body is needed in the HistoryView.

For large repositories this saves a lot of memory, e.g. about 110 MB for
linux kernel.

JGit-Dependency: I9291ba8c34c8744bc009b1bd302ed28bfa4e9476
Change-Id: I1504a6127e7fc2ebea67baade5e9799b256ab116


COMMENTS

author: Leslie Stephenson
date: 2012-05-29 20:50:37.000000000

Patch Set 1: I would prefer that you didn't submit this

I've got an NPE during linux 2.6 history review with this change:

java.lang.NullPointerException
	at org.eclipse.jgit.util.RawParseUtils.tagger(RawParseUtils.java:606)
	at org.eclipse.jgit.revwalk.RevTag.getTaggerIdent(RevTag.java:187)
	at org.eclipse.jgit.revplot.PlotWalk$PlotRefComparator.timeof(PlotWalk.java:175)
	at org.eclipse.jgit.revplot.PlotWalk$PlotRefComparator.compare(PlotWalk.java:154)
	at org.eclipse.jgit.revplot.PlotWalk$PlotRefComparator.compare(PlotWalk.java:1)
	at java.util.TimSort.countRunAndMakeAscending(TimSort.java:324)
	at java.util.TimSort.sort(TimSort.java:189)
	at java.util.TimSort.sort(TimSort.java:173)
	at java.util.Arrays.sort(Arrays.java:659)
	at org.eclipse.jgit.revplot.PlotWalk.getRefs(PlotWalk.java:144)
	at org.eclipse.jgit.revplot.PlotWalk.next(PlotWalk.java:134)
	at org.eclipse.jgit.revwalk.RevCommitList.fillTo(RevCommitList.java:331)
	at org.eclipse.egit.ui.internal.history.GenerateHistoryJob.run(GenerateHistoryJob.java:91)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

-------------------------------------
author: Carlie Harper
date: 2012-05-30 07:26:24.000000000

Patch Set 1:

Hi Dariusz,

did you use JGit with Change I9291ba8c34c8744bc009b1bd302ed28bfa4e9476? I think with that there should not be such an Exception.

Best Regards,
Stefan

-------------------------------------
author: Leslie Stephenson
date: 2012-05-30 16:40:06.000000000

Patch Set 1:

now with change #6150 I got compile error in GenerateHistoryJob:

The method fillTo(int) in the type RevCommitList<PlotCommit<SWTCommitList.SWTLane>> is not applicable for the arguments (RevCommit, int)

-------------------------------------
