DESCRIPTION

Prevent listener leak in properties page

Store the listener handle provided when the listener
is added and remove the handle when the page's control
is disposed.

Change-Id: Ia4ff8a821b0a0b694115e0a4a8c9b01c26a285c9


COMMENTS

author: Brenden Conley
date: 2012-05-08 15:24:11.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2937/ 

-------------------------------------
author: Brenden Conley
date: 2012-05-08 15:43:58.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2937/ : UNSTABLE

-------------------------------------
author: Leslie Stephenson
date: 2012-05-17 19:43:53.000000000

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)



Line:79, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySourceProvider.java -> is there any reason why not use here listenerHandle directly ?

-------------------------------------
author: Jaidyn Nichols
date: 2012-05-17 19:48:31.000000000

Patch Set 1: (1 inline comment)



Line:79, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySourceProvider.java -> Just to safeguard against multiple threads accessing and updating this field

-------------------------------------
