DESCRIPTION

[historyView] Do not store the RevWalk as a field in GitHistoryPage

When the history is redrawn a new RevWalk is created and configured
corresponding to the settings of the history view. This RevWalk is used
in the scheduled GenerateHistoryJob.

The RevWalk was stored in a field in the GitHistoryPage, although it is
not a property of such a Page. This can potentially lead to problem, and
indeed it caused bug 374675 which was fixed by
3604b5cd5fbf6ac354bc2a247115df7eade81959.

By passing it as a parameter the scope of the RevWalk instance is made
clearer.

Change-Id: I340f2a3cc7340dec781c09b8b8ced6a3fb03bdc5
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Carlie Harper
date: 2012-04-30 10:48:51.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2012-04-30 10:48:55.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2895/ 

-------------------------------------
author: Danika Greer
date: 2012-04-30 10:54:32.000000000

Patch Set 2: (5 inline comments)



Line:1701, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Here also newWalk -> walk

Line:1823, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Here also newWalk -> walk

Line:1834, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Here also newWalk -> walk

Line:1841, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Here also newWalk -> walk

Line:1848, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Here also newWalk -> walk

-------------------------------------
author: Brenden Conley
date: 2012-04-30 11:11:07.000000000

Patch Set 2: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2895/ : UNSTABLE

-------------------------------------
author: Carlie Harper
date: 2012-04-30 12:05:42.000000000

Patch Set 2: (5 inline comments)

Thanks for finding that.

Line:1701, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Done

Line:1823, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Done

Line:1834, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Done

Line:1841, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Done

Line:1848, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java -> Done

-------------------------------------
