DESCRIPTION

Prevent from NPE in RevUtils.getCommonAncestor

Bug: 373671
Change-Id: I98a3a2a9f4f8336429d9465267e4ebbf8984a3c0
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2012-04-26 10:45:16.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2880/ 

-------------------------------------
author: Brenden Conley
date: 2012-04-26 11:03:23.000000000

Patch Set 1: Verified

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2880/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2012-04-27 13:05:45.000000000

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)



Line:49, org.eclipse.egit.core/src/org/eclipse/egit/core/RevUtils.java -> I don't think getting the merge base with just one start point (or even no start point) makes any sense. What is the result of that?

So generally, shouldn't the caller check the arguments?

-------------------------------------
author: Leslie Stephenson
date: 2012-05-05 20:36:31.000000000

Patch Set 1: (1 inline comment)



Line:49, org.eclipse.egit.core/src/org/eclipse/egit/core/RevUtils.java -> You are right Robin this should be checked by callers

-------------------------------------
