DESCRIPTION

Change SubProgressMonitor to SubMonitor in org.eclipse.egit.core 

SubProgressMonitor has bad performance characteristics and SubMonitor
was offered 2007 as replacement for it. Platform recently deprecated
SubProgressMonitor and continues to improve performance of SubMonitor.
For org.eclipse.egit.core.internal.util, org.eclipse.egit.core.op and
org.eclipse.egit.core.project

Bug: 477695 
Change-Id: I1652625c5eb4d3e911f0128464fd1e6318fc6f63
Signed-off-by: Sasha xxx@xxx.xxx

COMMENTS

author: Sasha Hale
date: 2015-10-02 13:48:17.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2015-10-02 13:48:24.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7717/

-------------------------------------
author: Brenden Conley
date: 2015-10-02 14:11:46.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7717/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2015-10-11 19:32:55.000000000

Patch Set 8: Code-Review-1

(8 comments)

Looks fairly well as far as I see, but still some minor points. Will need corresponding changes in egit.ui to get proper progress reporting in all cases. For instance, GitImportWizard.importProject() should use SubMonitor to get a smooth progression.

Line:34, org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java -> ??

Line:96, org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java -> Why * 100? Wouldn't simply projects.size() and then newChild(1) below be clearer?

Line:162, org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java -> subMon.newChild(10)

Line:181, org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java -> Why this? Just pass through 'monitor'.

Line:102, org.eclipse.egit.core/src/org/eclipse/egit/core/op/IgnoreOperation.java -> Needs to be in an else-clause, otherwise you'll count twice (newChild() and worked()) and thus reach 100% before the last path.

Line:128, org.eclipse.egit.core/src/org/eclipse/egit/core/op/IgnoreOperation.java -> Remove...

Line:179, org.eclipse.egit.core/src/org/eclipse/egit/core/op/IgnoreOperation.java -> ... and just pass through 'monitor' here and below.

Line:228, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/util/ProjectUtil.java -> Not needed, delete.

-------------------------------------
author: Alayna Houston
date: 2015-10-12 11:34:29.000000000

Patch Set 8:

(3 comments)

Line:155, org.eclipse.egit.core/src/org/eclipse/egit/core/project/RepositoryFinder.java -> progress.setWorkRemaining(children.length);

Line:160, org.eclipse.egit.core/src/org/eclipse/egit/core/project/RepositoryFinder.java -> 1

Line:163, org.eclipse.egit.core/src/org/eclipse/egit/core/project/RepositoryFinder.java -> 1

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-10-18 22:53:15.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
