DESCRIPTION

Added check for warnings and errors before commit

Bug: 475559
Change-Id: I352c33d0fed1b610babda2992c6b1b211952dfb2
Signed-off-by: Reilly Hart xxx@xxx.xxx

COMMENTS

author: Reilly Hart
date: 2015-08-28 14:27:02.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2015-08-28 14:27:08.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7481/

-------------------------------------
author: Brenden Conley
date: 2015-08-28 14:50:16.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/7481/ : UNSTABLE

-------------------------------------
author: Reilly Hart
date: 2015-08-28 15:01:21.000000000

Patch Set 4: Code-Review+1

-------------------------------------
author: Brenden Conley
date: 2015-08-28 15:12:03.000000000

Patch Set 4: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7483/

-------------------------------------
author: Brenden Conley
date: 2015-08-28 15:35:04.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7483/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-08-28 15:38:47.000000000

Patch Set 4:

> in the first try I once observed that the commit button in the
 > staging view wasn't disabled despite the fact that the changes to
 > be commited had errors and warnings and checking was on. Looks like
 > some initialization problem though I couldn't reproduce that.
 > /\
 > maybe because the files wasn't in staged changes?

no I had a staged file with warnings

-------------------------------------
author: Reilly Hart
date: 2015-08-28 15:49:36.000000000

Patch Set 4: -Code-Review

I'll investigate this bug. Anything else?

-------------------------------------
author: Reilly Hart
date: 2015-08-31 06:59:31.000000000

Patch Set 4: Code-Review+1

-------------------------------------
author: Jayvion Booth
date: 2015-09-01 18:59:57.000000000

Patch Set 4: Code-Review-1

I've got staging view unresponsible due this NPE, because initially the button is NOT created so after switching the option and trying to select another repository staging view fails with NPE below.

Additionally I personally would put the prefrence to the "Commit" section.


!ENTRY org.eclipse.ui 4 0 2015-09-01 20:48:19.059
!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:4491)
	at org.eclipse.swt.SWT.error(SWT.java:4406)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:138)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3794)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3433)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:157)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
Caused by: java.lang.NullPointerException
	at org.eclipse.egit.ui.internal.staging.StagingView$51.run(StagingView.java:2594)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	... 24 more

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-09-11 23:59:01.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
