DESCRIPTION

Fix EclipseAuthenticator which was breaking platform's authenticator

When EclipseAuthenticator didn't find a proxy configuration it broke
platform's NetAuthenticator which shows a password dialog. If there is
no proxy configuration delegate to NetAuthenticator to fix this.

NetAuthenticator should be enhanced to respect proxy configuration so
that we can remove EclipseAuthenticator. Until then accept dependency to
an internal platform package.

Bug: 368882
Change-Id: Ibf5c587c0a9ff549faf6ef24175e0fb986be82f5
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2015-08-24 07:37:58.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-08-24 07:38:04.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/768/

-------------------------------------
author: Brenden Conley
date: 2015-08-24 08:18:10.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/768/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-24 08:33:46.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/769/

-------------------------------------
author: Brenden Conley
date: 2015-08-24 09:13:53.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/769/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-24 22:24:46.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/773/

-------------------------------------
author: Brenden Conley
date: 2015-08-24 23:04:48.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/773/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-25 08:44:42.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/774/

-------------------------------------
author: Brenden Conley
date: 2015-08-25 09:24:49.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/774/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-25 13:07:07.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/775/

-------------------------------------
author: Brenden Conley
date: 2015-08-25 13:47:26.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/775/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-25 15:38:09.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/776/

-------------------------------------
author: Brenden Conley
date: 2015-08-25 15:52:28.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/776/ : ABORTED

-------------------------------------
author: Brenden Conley
date: 2015-08-25 15:52:35.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/777/

-------------------------------------
author: Brenden Conley
date: 2015-08-25 16:32:43.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/777/ : ABORTED

-------------------------------------
author: Douglas Trujillo
date: 2015-08-26 12:43:30.000000000

Patch Set 1: Code-Review-1

This break EGit authentication for http(s):

When a request is sent initially without credentials in order to find out which authentication the server wants the server responds with status code "401 - Unauthorized" to request authentication. Then HttpUrlConnection asks the authenticator for credentials and that raises a dialog so that EGit/JGit can't use their own credentials provider which would return what was configured in EGit or is stored in the secure store ;-(

-------------------------------------
