DESCRIPTION

Initializing a Gitflow repository should allow changing branch names

- added new dialog that opens when initializing the repository
- changed API for "git flow init" to accept a config PoJo
- deprecated redundant API
- added UI test

Bug: 475293
Change-Id: If7e314d749b0fcd3e77eb82576336c1aa20d4d14
Signed-off-by: Jamarion Hunt xxx@xxx.xxx

COMMENTS

author: Jamarion Hunt
date: 2015-08-24 07:47:08.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-08-24 07:47:14.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7455/

-------------------------------------
author: Brenden Conley
date: 2015-08-24 08:08:42.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7455/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-08-24 08:33:26.000000000

Patch Set 3:

(2 comments)

Line:131, org.eclipse.egit.gitflow.test/src/org/eclipse/egit/gitflow/GitFlowRepositoryTest.java -> if InitParameters would have a fluent API this could be written as

 new InitParameters().setDevelop(DEVELOP)
		.setMaster(GitFlowDefaults.MASTER)
		.setFeature(FEATURE_PREFIX).setRelease(RELEASE_PREFIX)
		.setHotfix(HOTFIX_PREFIX).setVersionTag(VERSION_TAG)

Line:23, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/InitParameters.java -> I suggest you make this a fluent API by letting all setters return this

-------------------------------------
author: Jamarion Hunt
date: 2015-08-24 10:17:18.000000000

Patch Set 3:

(1 comment)

Line:131, org.eclipse.egit.gitflow.test/src/org/eclipse/egit/gitflow/GitFlowRepositoryTest.java -> Unfortunately, this causes problems with the reflective calls triggered by databinding, and the UI-test will fail: I.e.:
IAE "Missing public setter method for versionTag property"

-------------------------------------
author: Douglas Trujillo
date: 2015-08-24 15:07:45.000000000

Patch Set 3: Code-Review+2

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-08-24 15:07:49.000000000

Change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-08-24 20:17:21.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
