DESCRIPTION

Add a "Previous Version" option to the Replace With menu

Change-Id: I4b140e254c76477ba644b15eb77286d65887515c


COMMENTS

author: Willow Cantrell
date: 2012-03-21 18:58:35.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2012-03-21 19:07:55.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2739/ 

-------------------------------------
author: Brenden Conley
date: 2012-03-21 19:25:39.000000000

Patch Set 3: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2739/ : UNSTABLE

-------------------------------------
author: Jaidyn Nichols
date: 2012-03-21 19:36:27.000000000

Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)



Line:308, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> These should be the same as CompareWithPreviousActionHandler_MessageRevisionNotFound and CompareWithPreviousActionHandler_TitleRevisionNotFound

Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/ReplaceWithPreviousActionHandler.java -> A path limited RevWalk is needed here to find the commit that last modified the file at the selected path or else the previous commit may contain the exact same version of the file as the HEAD version.

See CompareWithPreviousActionHandler for an example to use.

-------------------------------------
author: Willow Cantrell
date: 2012-03-23 14:11:42.000000000

Patch Set 3: (1 inline comment)

For some reason, Gerrit doesn't show me your inline comment on the uitext.properties...

Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/ReplaceWithPreviousActionHandler.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2012-03-23 14:14:42.000000000

Patch Set 3:

Ok, found your comment using "unified" view.

-------------------------------------
author: Willow Cantrell
date: 2012-03-23 14:35:23.000000000

Patch Set 3: (1 inline comment)



Line:308, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done (patch set 5).

-------------------------------------
