DESCRIPTION

Bug 441357 - Add Spec button in push dialog has unexpected tab order
position 


Change-Id: Ic0941aacdb4629de052e3a24865421366054cdda
Signed-off-by: Emmanuel Weeks xxx@xxx.xxx


COMMENTS

author: Emmanuel Weeks
date: 2015-07-24 18:48:36.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-07-24 18:48:42.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7328/

-------------------------------------
author: Brenden Conley
date: 2015-07-24 19:11:27.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7328/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-07-24 21:24:13.000000000

Patch Set 1:

(1 comment)

- the fix works like a charm, thanks :-)
- some nits in the commit message, I'll fix them in a minute

Line:7, /COMMIT_MSG -> - style nit: we link to the bug in the commit message footer (and not in the header) as described in [1]
- the commit message header is too wide (see the warning in the staging view or commit message dialog)
- style nit: remove trailing whitespace
- in the commit message header describe what the change fixes, so better: "Fix unexpected tab order in push dialog's "Push refspec" page"

[1] https://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
author: Douglas Trujillo
date: 2015-07-24 21:24:20.000000000

Patch Set 1: Code-Review-1

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-07-25 00:12:26.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
