DESCRIPTION

Support Change-Id when committing from EGit

Change-Id: Icf379e126e5c9d29af70b5e2110377e43ba22430
Signed-off-by: Juliet Cantu xxx@xxx.xxx


COMMENTS

author: Juliet Cantu
date: 2010-04-06 21:29:42.000000000

Patch Set 1: Looks good to me, but someone else must approve; IP review completed



-------------------------------------
author: Juliet Cantu
date: 2010-04-06 21:29:58.000000000

Patch Set 1:

Depends on I04334f84e76e83a4185283cb72ea0308b1cb4182

-------------------------------------
author: Ace Duncan
date: 2010-04-07 04:07:02.000000000

Patch Set 1: I would prefer that you didn't submit this; No score

...because it's better to provide a separate feature/plugin for Gerrit support. Yes, creating org.eclipse.egit.gerrit.ui (or even org.eclipse.egit.gerrit.core) for such change  looks like overkill now ;-)

(I changed my mind, so it's not -2)

Line:215, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitAction.java -> ObjectId parentId = null;

and remove this else

Line:360, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Please provide a constant at least for

   Text.DELIMITER + "Change-Id: "

or even for full Change-Id string like this

   Text.DELIMITER + "Change-Id: " + CHANGE_ID_REGEX

-------------------------------------
