DESCRIPTION

Update swtbot to 2.3.0

Change-Id: I9e5964cc417f09e19441beb13810d1cc78ea6ef6
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2015-07-01 07:18:12.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7241/

-------------------------------------
author: Brenden Conley
date: 2015-07-01 07:54:09.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/7241/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2015-07-01 07:57:38.000000000

Patch Set 2: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7242/

-------------------------------------
author: Brenden Conley
date: 2015-07-01 08:33:34.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/7242/ : UNSTABLE

-------------------------------------
author: Jayvion Booth
date: 2015-07-01 08:37:57.000000000

Patch Set 2: Code-Review-1

31 tests are reproducible failing with swt bot 2.3.0, with the error:

org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException: Could not find view matching: with title '"Synchronize"'
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:437)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:411)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntil(SWTBotFactory.java:399)
	at org.eclipse.swtbot.swt.finder.SWTBotFactory.waitUntilWidgetAppears(SWTBotFactory.java:381)
	at org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot.view(SWTWorkbenchBot.java:131)
	at org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot.viewByTitle(SWTWorkbenchBot.java:157)
	at org.eclipse.egit.ui.view.synchronize.SynchronizeViewWorkspaceModelTest.getCompareEditorForFileInWorkspaceModel(SynchronizeViewWorkspaceModelTest.java:344)
	at org.eclipse.egit.ui.view.synchronize.SynchronizeViewWorkspaceModelTest.shouldOpenCompareEditor(SynchronizeViewWorkspaceModelTest.java:128)

I don't know why swt bot has this issue, but what would happen if we to change the tests NOT to useSWTWorkbenchBot.viewByTitle but to use SWTWorkbenchBot.viewById.

-------------------------------------
author: Jayvion Booth
date: 2015-07-01 21:50:25.000000000

Patch Set 2:

I've just found that in the debugger the "Synchronize" view has  title "Synchronize (Git (GeneralProject))". We should use byId().

-------------------------------------
