DESCRIPTION

Make tracing 3.4 compatible and plug-in local

Sharing trace classes between plug-ins
is bad, as the OSGI tracing infrastructure
will write the ID of plug-in that exposes
the trace class into the trace file.
Instead the ID of the plug-in that is
writing the trace should be written.
This is achieved by obtaining a separate
Location for each plug-in.
In order to achieve 3.4. compatibility,
a temporary trace implementation using
System.out is used.

Bug: 306793

Change-Id: 	I2765961f9c0b886995e74b03404e1f20aadf7b28
Signed-off-by: Willow Cantrell xxx@xxx.xxx

COMMENTS

author: Willow Cantrell
date: 2010-04-07 09:23:38.000000000

Uploaded patch set 4.

-------------------------------------
author: Willow Cantrell
date: 2010-04-07 09:24:45.000000000

Patch Set 4: No score

Resubmit due to merge conflict.

-------------------------------------
author: Juliet Cantu
date: 2010-04-07 19:37:47.000000000

Patch Set 4: I would prefer that you didn't submit this; No score

Don't bother with ?y comments on CRs for now. A few
other cosmetics issues though.

As for the service tracker calls I cannot tell.

Line:16, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/trace/DebugTrace.java -> insert empty line here

Line:18, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/GitTraceLocation.java -> Extrra empty comment line.
This file has CRLF line endings

Line:92, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/GitTraceLocation.java -> uncessary empty line

Line:35, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/trace/GitTraceLocation.java -> CRLF line endings

Line:17, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/ITraceLocation.java -> extra empty line here.

I addition this file has CRLF line endings

Line:16, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/DebugTrace.java -> insert blank line here

-------------------------------------
author: Juliet Cantu
date: 2010-04-07 19:39:04.000000000

Patch Set 4:

Slightly longer commit message lines would be easier
to read also. 

Did you consider using the Plugin.getLog() interface?

-------------------------------------
author: Gerrit Johnathan Pham
date: 2010-04-09 08:55:19.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
author: Willow Cantrell
date: 2010-04-08 06:50:24.000000000

MISMATCHED INLINE COMMENT
Line:16, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/trace/DebugTrace.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2010-04-08 06:50:24.000000000

MISMATCHED INLINE COMMENT
Line:18, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/GitTraceLocation.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2010-04-08 06:50:24.000000000

MISMATCHED INLINE COMMENT
Line:92, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/GitTraceLocation.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2010-04-08 06:50:24.000000000

MISMATCHED INLINE COMMENT
Line:17, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/ITraceLocation.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2010-04-08 06:50:24.000000000

MISMATCHED INLINE COMMENT
Line:16, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/trace/DebugTrace.java -> Done

-------------------------------------
