DESCRIPTION

[gitflow] Add icon decorations to identify gitflow repositories

Bug 470626
Change-Id: Ibd489882dce1335e68dbe32a0881591bb260096f
Signed-off-by: Jamarion Hunt xxx@xxx.xxx

COMMENTS

author: Jamarion Hunt
date: 2015-08-15 17:42:44.000000000

Uploaded patch set 9: Commit message was updated.

-------------------------------------
author: Brenden Conley
date: 2015-08-15 18:20:59.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7423/

-------------------------------------
author: Brenden Conley
date: 2015-08-15 18:42:14.000000000

Patch Set 9: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7423/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-08-16 22:24:22.000000000

Patch Set 9: Code-Review-1

(14 comments)

Line:58, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/uitext.properties -> add a parameter to explain which image can't be loaded

Line:14, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/UIIcons.java -> wrong Activator, use org.eclipse.egit.gitflow.ui.Activator

Line:29, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/UIIcons.java -> since this icon represents git flow it should be named e.g. flow or git-flow

File Comment: org.eclipse.egit.gitflow.ui/icons/ovr/staged_renamed.gif -> I'll upload another proposal for a gitflow icon to bug 470626

Line:27, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> * style nit: unnecessary empy comment line
* s/annotations/decorations/

Line:42, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> shorten to one-line empty comment

Line:76, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> mark xxx@xxx.xxx

Line:112, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> this class could be private if the unused public constant is removed

Line:115, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> why is this unused constant needed ?

Line:122, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> member should be private

Line:124, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> member should be private

Line:139, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> * can be declared final
* it's a constant so the name should be all uppercase
* use a less generic and more descriptive name for this constant as you want to add more images to the same class

Line:180, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> this method seems unused

Line:9, /COMMIT_MSG -> missing colon: s/Bug/Bug:/

-------------------------------------
author: Jamarion Hunt
date: 2015-08-16 23:41:17.000000000

Patch Set 9:

(13 comments)

Line:58, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/uitext.properties -> Done

Line:14, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/UIIcons.java -> Done

Line:29, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/UIIcons.java -> Done

Line:27, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:42, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:76, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:112, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:115, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:122, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:124, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:139, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Maybe "initialized" is not clear in this context, but I meant it as in "git flow intialized". Other icons would be named after their branching state. E.g. "feature", "release", ...

Line:180, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/decorators/GitFlowLightweightDecorator.java -> Done

Line:9, /COMMIT_MSG -> Done

-------------------------------------
author: Jamarion Hunt
date: 2015-08-17 00:49:24.000000000

Patch Set 9:

(1 comment)

File Comment: org.eclipse.egit.gitflow.ui/icons/ovr/staged_renamed.gif -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2015-08-22 22:32:18.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
