DESCRIPTION

Allow to show/edit branch configuration

It should be possible to see/change branch configuration (upstream
configuration) when selecting a branch in the Repositories View.

A Properties View can be opened which will show the upstream
configuration for the selected branch. From there, it is possible to
open an editor for this configuration.

Alternatively, a right-click on the branch node will open the editor
directly.

Change-Id: I3976c90da855d7524cd9a64d765264e87622e36a
Signed-off-by: Willow Cantrell xxx@xxx.xxx
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Willow Cantrell
date: 2012-04-25 18:43:32.000000000

Uploaded patch set 9.

-------------------------------------
author: Brenden Conley
date: 2012-04-25 18:43:36.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2875/ 

-------------------------------------
author: Willow Cantrell
date: 2012-04-25 18:44:35.000000000

Patch Set 9:

* Added a wait for configuration change after closing the dialog

-------------------------------------
author: Brenden Conley
date: 2012-04-25 19:00:24.000000000

Patch Set 9: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2875/ : UNSTABLE

-------------------------------------
author: Willow Cantrell
date: 2012-04-25 19:21:41.000000000

Patch Set 9:

It seems that there are no configuration change events which causes the test to fail.

-------------------------------------
author: Douglas Trujillo
date: 2012-04-25 22:58:57.000000000

Patch Set 9: I would prefer that you didn't submit this

(7 inline comments)



Line:66, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchConfigurationDialog.java -> should be BranchConfigurationDialog_BranchConfigurationTitle instead

Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchConfigurationDialog.java -> style nit: remove unnecessary curly braces

Line:478, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewBranchHandlingTest.java -> button(Window.OK) seems not to be able to find the ok button hence no event is fired, I found that button("OK") works :-)

with that we don't need the wait loop

Line:487, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewBranchHandlingTest.java -> s/gotten/received/

Line:882, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> unnecessary string, the next entry (BranchConfigurationDialog_BranchConfigurationTitle) is sufficient

Line:884, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> wrong case: s/Upstream/upstream s/Branch/branch/

Line:888, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> wrong case

-------------------------------------
author: Douglas Trujillo
date: 2012-04-25 23:02:20.000000000

Patch Set 9: (7 inline comments)



Line:66, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchConfigurationDialog.java -> Done

Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchConfigurationDialog.java -> Done

Line:478, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewBranchHandlingTest.java -> Done

Line:487, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewBranchHandlingTest.java -> Done

Line:882, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

Line:884, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

Line:888, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> Done

-------------------------------------
