DESCRIPTION

Allow to save patches in Workspace 

Bug: 368774
Change-Id: Ib3f78eceaea6f9ca3f916622d836b1d39613fd08


COMMENTS

author: Brenden Conley
date: 2012-01-18 23:16:20.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2370/ 

-------------------------------------
author: Brenden Conley
date: 2012-01-18 23:33:13.000000000

Patch Set 1: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2370/ : SUCCESS

-------------------------------------
author: Leslie Stephenson
date: 2012-01-21 14:42:18.000000000

Patch Set 1: I would prefer that you didn't submit this

(15 inline comments)

please see my inline comments

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> IMHO you should also add yourself to contributors list

Line:170, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> style-nit: don't use curly brackets around single line blocks

Line:232, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> remove this empty line

Line:236, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> is there any purpose to use javadosc inside private method body ?

Line:242, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> is there any purpose to use javadosc inside private method body ?

Line:266, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> I would consider extracting this class into standalone file

Line:290, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> is there any reasons why you didn't mark this class as a private ?

Line:292, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> sytle-nit: we prefer to have a space before and after '=' character

Line:302, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> why didn't you use here a foreach loop ?

Line:303, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> sytle-nit: don't use curly brackets around single line blocks

Line:313, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> is there any reasons why you didn't mark this class as a private ?

Line:455, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> style-nit: don't use curly brackets around single line blocks

Line:457, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> style-nit: don't use curly brackets around single line blocks

Line:783, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> style-nit: add space after equals character

Line:812, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java -> style-nit: don't use curly brackets around single line blocks

-------------------------------------
