DESCRIPTION

Don't use RepositoryProvider.getProvider() to avoid deadlocks

Added ResourceUtil.getGitProvider(IProject) and
ResourceUtil.isSharedWithGit(IResource) utility methods which mimics the
code in the RepositoryProvider.getProvider() without accessing any
locks.

Bug: 469555
Change-Id: I2349280b7fe73289a2a1cd9e8c802f8f7499327c
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2015-06-23 22:36:43.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-06-23 22:36:50.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7160/

-------------------------------------
author: Jayvion Booth
date: 2015-06-23 22:37:21.000000000

Removed the following approvals:

* Code-Review-2 by Jayvion Booth xxx@xxx.xxx


-------------------------------------
author: Brenden Conley
date: 2015-06-23 22:53:18.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7160/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2015-06-24 12:34:08.000000000

Patch Set 2: Verified-1

seems to fix deadlock but I have now two new errors:

!ENTRY org.eclipse.core.jobs 4 2 2015-06-24 11:48:11.037
!MESSAGE An internal error occurred during: "Auto share git projects".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.egit.core.project.RepositoryMapping.<init>(RepositoryMapping.java:91)
	at org.eclipse.egit.core.project.RepositoryFinder.register(RepositoryFinder.java:204)
	at org.eclipse.egit.core.project.RepositoryFinder.findInDirectory(RepositoryFinder.java:196)
	at org.eclipse.egit.core.project.RepositoryFinder.findInDirectoryAndParents(RepositoryFinder.java:176)
	at org.eclipse.egit.core.project.RepositoryFinder.find(RepositoryFinder.java:146)
	at org.eclipse.egit.core.project.RepositoryFinder.find(RepositoryFinder.java:128)
	at org.eclipse.egit.core.project.RepositoryFinder.find(RepositoryFinder.java:104)
	at org.eclipse.egit.core.Activator$CheckProjectsToShare.visitConnect(Activator.java:426)
	at org.eclipse.egit.core.Activator$CheckProjectsToShare.run(Activator.java:392)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

!MESSAGE An internal error occurred during: "Auto share git projects".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.egit.core.Activator$CheckProjectsToShare.visitConnect(Activator.java:433)
	at org.eclipse.egit.core.Activator$CheckProjectsToShare.run(Activator.java:392)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

-------------------------------------
