DESCRIPTION

Show lightweight tags in commit editor

Bug: 368178
Change-Id: Ib46f1bb11c8b505616e9464e12d3bce3c22bf191


COMMENTS

author: Jaidyn Nichols
date: 2012-01-10 23:44:14.000000000

Uploaded patch set 5.

-------------------------------------
author: Juliet Cantu
date: 2012-01-10 23:50:09.000000000

Patch Set 5: I would prefer that you didn't submit this



-------------------------------------
author: Jaidyn Nichols
date: 2012-01-10 23:51:02.000000000

Patch Set 5:

What was the reason for the -1 on the latest version?

-------------------------------------
author: Brenden Conley
date: 2012-01-10 23:55:41.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2290/ 

-------------------------------------
author: Brenden Conley
date: 2012-01-11 00:10:56.000000000

Patch Set 5: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2290/ : SUCCESS

-------------------------------------
author: Juliet Cantu
date: 2012-01-11 07:27:15.000000000

Patch Set 5:

>What was the reason for the -1 on the latest version?

Because the patch is a duplicate of what's already posted to gerrit.

-------------------------------------
author: Jaidyn Nichols
date: 2012-01-11 15:33:57.000000000

Patch Set 5:

The change you link to modifies CommitFileRevision only.  This class is not used by CommitEditorPage (the file this change modified) and therefore does not impact support for showing lightweight tags in the commit editor.

Am I missing something?

-------------------------------------
author: Juliet Cantu
date: 2012-01-11 20:18:30.000000000

Patch Set 5:

The linked patch depends on http://egit.eclipse.org/r/#change,4887 which modified the commit editor

-------------------------------------
author: Jaidyn Nichols
date: 2012-01-11 20:30:55.000000000

Patch Set 5:

That change updates the commit details in the History view, this change updates the UI that displays a commit in the editor area.

-------------------------------------
author: Juliet Cantu
date: 2012-01-11 23:09:27.000000000

Patch Set 5: Looks good to me, but someone else must approve; IP review completed

Ok

-------------------------------------
author: Juliet Cantu
date: 2012-01-11 23:55:33.000000000

Patch Set 5: Looks good to me, approved; Build Successful



-------------------------------------
author: Juliet Cantu
date: 2012-01-11 23:55:34.000000000

Change has been successfully merged into the git repository.

-------------------------------------
