DESCRIPTION

Import projects provides group-by folder view

In order to easily import projects from repositories, the project import
wizard groups projects by their subfolder. In case of a repository with
different components (eg. features, bundles, doc, ..), the user can
easily select all projects for one subfolder.

Bug: 367146
Change-Id: I8a2bb0a120a8c1df45e22be09bf216bd35ba0529
Signed-off-by: Marley Hopkins xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2012-01-04 11:05:49.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2219/ 

-------------------------------------
author: Brenden Conley
date: 2012-01-04 11:21:05.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2219/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2012-01-04 23:42:41.000000000

Patch Set 1: I would prefer that you didn't submit this; IP review completed

(7 inline comments)

works nicely

but when running all the ui tests the new test is failing reproducably, looks like some cleanup is missing:

Rerun org.eclipse.egit.ui.wizards.clone.GitCloneWizardTest
org.eclipse.egit.ui.wizards.clone.GitCloneWizardTest
importSubProjects(org.eclipse.egit.ui.wizards.clone.GitCloneWizardTest)
java.lang.IllegalStateException: Repository already exists: /Users/d029788/LocalRepositoriesTests/FirstRepository/.git
	at org.eclipse.jgit.storage.file.FileRepository.create(FileRepository.java:245)
	at org.eclipse.jgit.lib.Repository.create(Repository.java:165)
	at org.eclipse.egit.ui.common.LocalRepositoryTestCase.createProjectAndCommitToRepository(LocalRepositoryTestCase.java:200)
	at org.eclipse.egit.ui.common.LocalRepositoryTestCase.createProjectAndCommitToRepository(LocalRepositoryTestCase.java:191)
	at org.eclipse.egit.ui.wizards.clone.GitCloneWizardTest.importSubProjects(GitCloneWizardTest.java:303)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.run(SWTBotJunit4ClassRunner.java:54)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.swtbot.eclipse.core.RemotePluginTestRunner.main(RemotePluginTestRunner.java:64)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.runTests(UITestApplication.java:117)
	at org.eclipse.ui.internal.testing.WorkbenchTestable$1.run(WorkbenchTestable.java:71)
	at java.lang.Thread.run(Thread.java:680)

Line:140, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:268, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:279, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:485, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:525, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:645, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java -> style nit: no braces around single line blocks

Line:291, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> style nit: trailing whitespace, more below

-------------------------------------
author: Marley Hopkins
date: 2013-12-13 10:55:33.000000000

Abandoned

Not working on this right now.

-------------------------------------
