DESCRIPTION

Add an icon attribute to the cloneSourceProvider extension point

Change-Id: Ibac3450de851351131fe57e6bb7c78a2fc3d4d49
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Carlie Harper
date: 2012-01-19 12:53:54.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2012-01-19 18:24:16.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2386/ 

-------------------------------------
author: Brenden Conley
date: 2012-01-19 18:47:47.000000000

Patch Set 7: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2386/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2012-01-20 07:41:33.000000000

Patch Set 7: I would prefer that you didn't submit this

(3 inline comments)



Line:65, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> this line looks a bit too wide

Line:51, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationLabelProvider.java -> style nit: no braces around single line blocks

Line:75, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> why isn't this line indented ?

-------------------------------------
author: Carlie Harper
date: 2012-01-24 13:40:17.000000000

Patch Set 7: (3 inline comments)



Line:65, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:51, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationLabelProvider.java -> Done

Line:75, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> I think that this is a bug in the form based editor. When I indent it in the source, the editor will include all the spaces into the test box which looks ugly. What should we prefer?

-------------------------------------
