DESCRIPTION

Redesign GitImportWizard to include contributed clone sources

The GitImportWizard now includes the extensions of the
org.eclipse.egit.ui.cloneSourceProvider. The flow of pages is the same
as described in the Mock-Up which is attached to Bug 361251.

Bug: 361251
Change-Id: I957ee48121b24fd78a91fe5e2855130c4614649f
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2011-12-19 23:56:31.000000000

Patch Set 1: I would prefer that you didn't submit this

(13 inline comments)



Line:31, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> so this is work in progress ?

Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> same question here

Line:102, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> nit: no braces around single line block

Line:30, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationLabelProvider.java -> remove TODO ?

Line:1, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/SelectImportWizardPage.java -> missing license header

Line:6, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/SelectImportWizardPage.java -> dead code ?

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> should be 2010-2011 ?

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> why are you removing Mathias here ?
your contribution is obviously not initial

Line:74, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> exception handling ?

Line:111, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> typo

Line:119, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> externalize string ?

Line:143, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> style nit: why these blank lines ?

Line:2, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepositoryLocationPage.java -> we have 2011

-------------------------------------
author: Carlie Harper
date: 2011-12-20 17:00:21.000000000

Patch Set 1: (13 inline comments)



Line:31, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> Done

Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> Done

Line:102, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationContentProvider.java -> Done

Line:30, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/RepositoryLocationLabelProvider.java -> Done

Line:1, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/SelectImportWizardPage.java -> I remove this class.

Line:6, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/SelectImportWizardPage.java -> I remove this class.

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:9, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:74, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:111, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:119, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:143, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java -> Done

Line:2, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/RepositoryLocationPage.java -> I remove this class, it is not yet needed.

-------------------------------------
