DESCRIPTION

Add an extension point to provide repository search

The new extension point can be used to contribute the ability to search
for repositories on a remote server. It will be used in a new version of
an import wizard. For this use case an implementor can provide a Wizard
page implementing such a search.

Bug: 361251
Change-Id: I4e3a3ff88dbb5642dd61c55d751f4be12e93f720
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Carlie Harper
date: 2012-01-09 14:55:54.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2012-01-09 16:31:39.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2278/ 

-------------------------------------
author: Brenden Conley
date: 2012-01-09 16:48:17.000000000

Patch Set 3: Build Successful

Build Successful 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2278/ : SUCCESS

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:06.000000000

Patch Set 3: I would prefer that you didn't submit this

(22 inline comments)

+1 for the idea, but there are some minor issues

-------------------------------------
author: Carlie Harper
date: 2012-01-19 12:48:10.000000000

Patch Set 3: (22 inline comments)



Line:20, org.eclipse.egit.ui/plugin.properties -> Done

Line:87, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:89, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:91, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:127, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:146, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> Done

Line:31, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/RepositoryServerInfo.java -> Done

Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/IRepositorySearchResult.java -> Done

Line:34, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:59, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:61, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:63, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> Done

Line:28, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> Done

Line:35, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> Done

Line:42, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> Done

Line:160, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> Done

Line:30, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/IRepositoryServerProvider.java -> Done

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:20, org.eclipse.egit.ui/plugin.properties -> this property seams to be not used

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:87, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> this can be final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:89, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> this can be final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:91, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> this can be final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:127, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> style nit: we don't use curly brackets around single line blocks

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:146, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCloneSourceProviderExtension.java -> style nit: curly brackets

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:31, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/RepositoryServerInfo.java -> uri and label fields can be marked as final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/IRepositorySearchResult.java -> I would add empty line between method name and closing "}"

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:34, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> this can be final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> missing java doc

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> can be final, why it its publicly accessible and don't you use getters/setters ?

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:41, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> same as above

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> same as above

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:59, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> same as aboce

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:61, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> same as above

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:63, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> same as above

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/GitRepositoryInfo.java -> can be marked as final

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:28, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> tyle nit: trailing whitespace

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:35, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> tyle nit: trailing whitespace

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:42, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> tyle nit: trailing whitespace

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:160, org.eclipse.egit.ui/schema/cloneSourceProvider.exsd -> tyle nit: trailing whitespace

-------------------------------------
author: Leslie Stephenson
date: 2012-01-17 10:54:05.000000000

MISMATCHED INLINE COMMENT
Line:30, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/provisional/wizards/IRepositoryServerProvider.java -> I would add empty line between method and closing "}"

-------------------------------------
