DESCRIPTION

Team > Create patch is missing 

Bug: 341036
Change-Id: Ib32830d732d31c1057ed7c969399f21223908b06


COMMENTS

author: Brenden Conley
date: 2011-12-14 15:02:58.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2165/ 

-------------------------------------
author: Brenden Conley
date: 2011-12-14 15:03:53.000000000

Patch Set 1: Build Failed

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2165/ : FAILURE

-------------------------------------
author: Douglas Trujillo
date: 2011-12-14 22:39:56.000000000

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

- the new team menu entry should reside in the same group with "Apply Patch"
- when checking the option to create git patch ("Export in git patch format") I hit an NPE

!ENTRY org.eclipse.egit.ui 4 0 2011-12-14 23:39:02.339
!MESSAGE Patch file was not written
!STACK 0
java.lang.reflect.InvocationTargetException
	at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:421)
	at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1029)
	at org.eclipse.egit.ui.internal.history.GitCreatePatchWizard.performFinish(GitCreatePatchWizard.java:148)
	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4128)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1457)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1480)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1465)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1270)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3974)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3613)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.egit.ui.internal.history.GitCreatePatchWizard.run(GitCreatePatchWizard.java:91)
	at org.eclipse.egit.ui.internal.patch.PatchOperationUI.start(PatchOperationUI.java:90)
	at org.eclipse.egit.ui.internal.actions.CreatePatchActionHandler.execute(CreatePatchActionHandler.java:21)
	at org.eclipse.egit.ui.internal.actions.RepositoryAction.run(RepositoryAction.java:86)
	at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4128)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1457)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1480)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1465)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1270)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3974)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3613)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Caused by: java.lang.NullPointerException
	at org.eclipse.egit.core.op.CreatePatchOperation.writeGitPatchHeader(CreatePatchOperation.java:160)
	at org.eclipse.egit.core.op.CreatePatchOperation.execute(CreatePatchOperation.java:105)
	at org.eclipse.egit.ui.internal.history.GitCreatePatchWizard$1.run(GitCreatePatchWizard.java:152)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Root exception:
java.lang.NullPointerException
	at org.eclipse.egit.core.op.CreatePatchOperation.writeGitPatchHeader(CreatePatchOperation.java:160)
	at org.eclipse.egit.core.op.CreatePatchOperation.execute(CreatePatchOperation.java:105)
	at org.eclipse.egit.ui.internal.history.GitCreatePatchWizard$1.run(GitCreatePatchWizard.java:152)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

Line:114, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java -> externalize error messages

Line:13, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CreatePatchAction.java -> style nit: unnecessary blank line

-------------------------------------
author: Douglas Trujillo
date: 2011-12-14 22:41:13.000000000

Patch Set 1: (1 inline comment)



Line:7, /COMMIT_MSG -> - style nit: trailing whitespace
- better explain what this change adds instead of explaining what's missing

-------------------------------------
author: Clay Cameron
date: 2011-12-15 11:24:47.000000000

Patch Set 1:

> the new team menu entry should reside in the same group with "Apply Patch"

In CVS the "Create Patch" action is under team.main/group1, while the "Apply Patch" is under team.main/applyPatchGroup. Now I see EGit uses a different layout, the "Apply Patch" action is under team.main/group6, and I put the "Create Patch" action under team.main/group1 just like in CVS.

-------------------------------------
author: Brenden Conley
date: 2011-12-22 12:14:27.000000000

Patch Set 1:

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2175/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2011-12-28 15:37:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2180/ 

-------------------------------------
author: Brenden Conley
date: 2011-12-28 15:42:49.000000000

Patch Set 1:

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2180/ : FAILURE

-------------------------------------
