DESCRIPTION

WIP: Adding CleanCommand functionality to 'Advanced' menu

Change-Id: I4bcf97da3e32b609dea6e49ef226daf6fd587777
Signed-off-by: Makenzie Simon xxx@xxx.xxx

Change-Id: I4bcf97da3e32b609dea6e49ef226daf6fd587777


COMMENTS

author: Makenzie Simon
date: 2011-12-14 06:32:59.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2011-12-14 06:33:03.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2158/ 

-------------------------------------
author: Brenden Conley
date: 2011-12-14 06:33:48.000000000

Patch Set 2: Build Failed

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2158/ : FAILURE

-------------------------------------
author: Juliet Cantu
date: 2011-12-15 00:27:47.000000000

Patch Set 2: I would prefer that you didn't submit this

(11 inline comments)

I cannot see the difference between a directory/submodule/repo and a file in the dialog.


This following failed. old is a directory with a .git directory inside it.. C Git does not clean it (though is says it does). In this case it is a nested repo, but we could have submodules. But should be handled nicely, Don't delete and tell the user in a decipherable way.


org.eclipse.jgit.api.errors.JGitInternalException: Could not delete file /Users/me/SW/myegit/JGIT/old
at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:97)
at org.eclipse.egit.core.op.CleanOperation.execute(CleanOperation.java:74)
at org.eclipse.egit.core.internal.job.JobUtil$1.run(JobUtil.java:50)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: java.io.IOException: Could not delete file /Users/me/SW/myegit/JGIT/old
at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:134)
at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:92)
at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:92)
... 3 more

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> What does this have to do with anything?

Line:99, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> we don't do this either

Line:105, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> Make the dialog much much wider.
I hate horizontal scroll bars.

Line:137, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> Don't leave away-commented code

Line:190, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> nit-pick: add a space after //

Line:256, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> Remove ///

Line:30, org.eclipse.egit/.project -> We declare dependencies via OSGI, not this way

Line:63, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> Gosh, how much can one ident?

Line:70, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> The dialog is way to narrow, make it at least twice as wide. I hate horizontal scroll bars.

Enable multi-selection, so I can mark a region and press space or whatever to select/deselect a range.

Line:70, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CleanOperation.java -> Not done yet?

Line:73, org.eclipse.egit.core/src/org/eclipse/egit/core/op/CleanOperation.java -> nit-pick: no braces for simple single-statement constructs

-------------------------------------
author: Douglas Trujillo
date: 2011-12-15 22:32:33.000000000

Patch Set 2: I would prefer that you didn't submit this

(15 inline comments)



Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> don't you want to use a consistent email address throughout this commit ?

Line:51, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> we don't use author tags, but we want javadoc for non-trivial public stuff

Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> this comment seems unnecessary, this looks obvious

Line:70, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> what the heck is this? We are not handling tags here ...

Line:86, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> how does this relate to tags ?

Line:125, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> why do we need a tag list here ?

Line:214, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> ? again why tags here ?

Line:251, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> tags ?

Line:275, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> don't use slang, better use setRepository()

Line:282, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> better name this getRepository()

Line:300, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CleanTreeDialog.java -> again why tags here ?

Line:30, org.eclipse.egit/.project -> add the OSGi dependencies in the manifest, project dependencies only work in Eclipse but won't in the maven build

Line:34, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> ? this is an action handler, the operation is another class or do I miss something ?

Line:71, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CleanActionHandler.java -> I think this is obvious, I would consider removing this comment

Line:7, /COMMIT_MSG -> we use [DRAFT] or [RFC] to mark unfinished changes

-------------------------------------
author: Douglas Trujillo
date: 2011-12-15 22:34:56.000000000

Patch Set 2: Unclean IP, do not check in

this is a rather big change hence we'll have to file a CQ to track the formal IP review, will do that when this change is close to acceptance

-------------------------------------
