DESCRIPTION

Bug 466486 - [CSS] [Dark] PushResultDialog not styled in dark them 

Converts anonymous inner class to inner class to have a better CSS
selector for it.
Adds Styling for the newly created selector

Change-Id: I6a106d63ef8201ba38d9cccbd3efe4c6646bd77b
Signed-off-by: Zaid Mosley xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2015-05-05 22:56:53.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-05-05 23:05:52.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6976/

-------------------------------------
author: Brenden Conley
date: 2015-05-05 23:09:11.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/6976/ : FAILURE

-------------------------------------
author: Douglas Trujillo
date: 2015-05-05 23:25:49.000000000

Patch Set 3: Code-Review-1

(5 comments)

Line:406, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/SpellcheckableMessageArea.java -> style nit: remove this unrelated formatting change

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> this inner class should be declared static

Line:207, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> style nit: this line looks too wide, we use max line width of 80 chars, best you use our formatter settings http://git.eclipse.org/c/egit/egit.git/tree/tools/eclipse-JGit-Format.xml

Line:7, /COMMIT_MSG -> we don't put the bug link in the header but in the footer, see the example in https://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

Line:7, /COMMIT_MSG -> The commit message header should describe what the change does, the tags [CSS} [Dark] seem unnecessary, so something like the following looks more readable:

 Properly style PushResultDialog in dark theme


s/them /theme/

-------------------------------------
author: Douglas Trujillo
date: 2015-05-05 23:28:42.000000000

Patch Set 3:

(5 comments)

Line:406, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/SpellcheckableMessageArea.java -> Done

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:207, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> my fault, this line wasn't touched in this change

Line:7, /COMMIT_MSG -> Done

Line:7, /COMMIT_MSG -> Done

-------------------------------------
