DESCRIPTION

Extend EGit to allow use of git-flow

Initial implementation:
- Operations for all commonly used git flow commands without optional
  parameters
- Menu contributions in the repository and history view, as well as the
  team menu on projects
- Added new feature as incubation project to update site
- Non-UI tests (see launch config)

Bug: 348610
Change-Id: I215ed28e6434a789fa7260d7072532b402a1e714
Signed-off-by: Jamarion Hunt xxx@xxx.xxx


COMMENTS

author: Jamarion Hunt
date: 2015-05-11 10:53:57.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2015-05-11 10:54:03.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7006/

-------------------------------------
author: Brenden Conley
date: 2015-05-11 11:10:34.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7006/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-05-11 12:59:07.000000000

Patch Set 5: Code-Review-1

(12 comments)

almost there :-) 

as soon as you fixed these issues I will file the CQ to trigger the IP review required at Eclipse for changes > 1000 LoC

Line:27, org.eclipse.egit.gitflow-feature/feature.xml -> we use this version requirement in other places:

 version="4.0.0" match="equivalent"

to express we require at least 4.0.0 and accept higher service level (3rd part of the version number maybe higher, see http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Ffeature_manifest.html

Line:29, org.eclipse.egit.gitflow-feature/feature.xml -> add the same version requirement as for jgit

Line:36, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/BranchNameValidator.java -> this is a new class so move the since tag to the class level

Line:13, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/internal/coretext.properties -> remove trailing whitespaces

Line:17, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/internal/coretext.properties -> looks like you didn't finish replacing string concatenation by parameters

Line:44, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/Activator.java -> put xxx@xxx.xxx 4.0 annotation on this new class instead of on each method

Line:24, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/WrongGitFlowStateException.java -> move since tag to class level

Line:37, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/JobUtil.java -> use the corresponding methods already available in org.eclipse.egit.core.internal.job.JobUtil instead

Line:72, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowConfig.java -> move since tag to class level

Line:32, org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/actions/GitFlowHandlerUtil.java -> why don't you simply use Utils.getAdapter() right away ?

Line:43, org.eclipse.egit.gitflow/src/org/eclipse/egit/gitflow/GitFlowRepository.java -> move since tag to class level

Line:5, org.eclipse.egit.gitflow/build.properties -> include about.html

-------------------------------------
