DESCRIPTION

[stagingView] Ensure reload occurs on UI-thread

This adds more guards and checks to the process of reloading
the staging view with a specified repository.  Reload clears
the current UI if a null repository is specified and so the
method should now always run on the UI-thread.  Also more strict
checks should be added to ensure the repository being displayed
is valid and registered.

Change-Id: I6f8cfca34c1baa4085b9c2f1e929d009a0cb0af0
Signed-off-by: Jaidyn Nichols xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2011-11-17 01:01:13.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2056/ 

-------------------------------------
author: Brenden Conley
date: 2011-11-17 01:02:13.000000000

Patch Set 1: Build Failed

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2056/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2011-11-17 15:02:30.000000000

Patch Set 1: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2067/ 

-------------------------------------
author: Brenden Conley
date: 2011-11-17 15:03:22.000000000

Patch Set 1: Build Failed

Build Failed 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2067/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2011-11-17 15:04:03.000000000

Patch Set 1: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/2068/ 

-------------------------------------
author: Brenden Conley
date: 2011-11-17 15:29:59.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/2068/ : UNSTABLE

-------------------------------------
author: Marlie Beasley
date: 2011-11-21 16:07:53.000000000

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)



Line:219, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> asyncReload is not required if reload can be called from any thread (see comment below).

Line:1052, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> I think reload should be callable from any thread.
This can be achieved by moving the repository == null block into an asyncExec.

-------------------------------------
author: Jaidyn Nichols
date: 2011-11-21 17:32:57.000000000

Patch Set 1: (2 inline comments)



Line:219, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> Done

Line:1052, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> Done

-------------------------------------
