DESCRIPTION

[repoView] Add operation to delete tags

One or more selected tags can now be deleted by select
the Delete Tag action in the context menu.

Bug: 337046
Change-Id: I7ac9ac819d4d1048604c936ab945b4d6fe31d6dd
Signed-off-by: Jaidyn Nichols xxx@xxx.xxx

COMMENTS

author: Jaidyn Nichols
date: 2011-11-10 18:19:45.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2011-11-10 18:22:18.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1983/ 

-------------------------------------
author: Brenden Conley
date: 2011-11-10 18:36:27.000000000

Patch Set 5: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1983/ : UNSTABLE

-------------------------------------
author: Leslie Stephenson
date: 2011-11-11 11:55:48.000000000

Patch Set 5: I would prefer that you didn't submit this

I got ClassCastException when tried to delete tag

java.lang.ClassCastException: org.eclipse.egit.ui.internal.repository.tree.TagNode cannot be cast to org.eclipse.egit.ui.internal.repository.tree.RemoteNode
	at org.eclipse.egit.ui.internal.repository.tree.command.RemoveRemoteCommand.execute(RemoveRemoteCommand.java:31)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:786)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:885)
	at org.eclipse.ui.internal.keys.OutOfOrderListener.handleEvent(OutOfOrderListener.java:76)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1282)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1267)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1294)
	at org.eclipse.swt.widgets.Widget.gtk_key_press_event(Widget.java:730)
	at org.eclipse.swt.widgets.Control.gtk_key_press_event(Control.java:3019)
	at org.eclipse.swt.widgets.Composite.gtk_key_press_event(Composite.java:734)
	at org.eclipse.swt.widgets.Tree.gtk_key_press_event(Tree.java:2002)
	at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1743)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:5016)
	at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:3530)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4408)
	at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
	at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:8422)
	at org.eclipse.swt.widgets.Display.eventProc(Display.java:1245)
	at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
	at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2276)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3207)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

-------------------------------------
author: Jaidyn Nichols
date: 2011-11-11 17:20:36.000000000

Patch Set 5:

That exception is unrelated to this change and is a bug introduced by: http://egit.eclipse.org/r/#change,4579

I just pushed a fix for it here: http://egit.eclipse.org/r/4601

-------------------------------------
author: Douglas Trujillo
date: 2011-11-11 20:46:34.000000000

Patch Set 5: I would prefer that you didn't submit this

found a failing scenario:
- create a couple of tags on different commits
- select 2 tags and click "Delete Tag"
- cancel the confirmation dialog
- select only one tag and click "Delete Tag"
- the confirmation dialog still asks if it's ok to delete 2 tags
- click ok
- both tags previously selected get deleted which is wrong

-------------------------------------
author: Douglas Trujillo
date: 2011-11-11 20:48:51.000000000

Patch Set 5: (1 inline comment)



Line:146, org.eclipse.egit.ui/plugin.properties -> there is a confirmation dialog, hence "Delete Tag..."

-------------------------------------
author: Jaidyn Nichols
date: 2011-11-11 20:51:53.000000000

Patch Set 5: (1 inline comment)

I'm having trouble reproducing the scenario where is prompts to delete 2 tags when only one tag is selected.

Line:146, org.eclipse.egit.ui/plugin.properties -> Done

-------------------------------------
