DESCRIPTION

Bug 463296 - GitResourceDeltaVisitor processes (purposeless) derived
resources

Change-Id: I0cc19a370802d238dce4555ca4718d851371662d
Signed-off-by: Lilah Bowers xxx@xxx.xxx

COMMENTS

author: Lilah Bowers
date: 2015-03-27 15:38:40.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-03-27 15:38:47.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6903/

-------------------------------------
author: Brenden Conley
date: 2015-03-27 15:43:26.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/6903/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2015-03-27 23:42:53.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6906/

-------------------------------------
author: Brenden Conley
date: 2015-03-28 00:02:35.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6906/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2015-03-28 00:07:36.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:70, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/GitResourceDeltaVisitor.java -> no, I think this is not ok since then EGit and git-core would show different status

you can already configure EGit to auto-ignore derived resources ("Preferences > Team > Git > Projects > Automatically ignore derived resources by adding them to .gitignore"). That's done by adding derived resources to .gitignore and this ensures git-core shows the same status as EGit does.

Line:206, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/GitResourceDeltaVisitor.java -> why do we need two implementations ? Couldn't we replace the current getFilesToUpdate() with this implementation

Line:7, /COMMIT_MSG -> style nits:

we reference the bug in the footer in the following format

 Bug: 463296

The commit message header is too wide, keep it < 70 characters,
see https://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
