DESCRIPTION

[wip] Comparison broken when model resource missing in other branch

Change-Id: I734c700aa326c3a7d276c0540056eaf3d5652644
Signed-off-by: Karter Mora xxx@xxx.xxx


COMMENTS

author: Rylee Bush
date: 2015-09-23 13:25:21.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-09-23 13:25:27.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/7674/

-------------------------------------
author: Brenden Conley
date: 2015-09-23 13:50:04.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/7674/ : SUCCESS

-------------------------------------
author: Mackenzie Page
date: 2015-09-23 14:13:26.000000000

Patch Set 3:

(1 comment)

Line:256, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java -> Without further thought and from a pure symmetry perspective, why is there not if case for input.getLeft() == null?

-------------------------------------
author: Rylee Bush
date: 2015-09-30 13:31:16.000000000

Patch Set 3:

(1 comment)

Line:256, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java -> input.getLeft can't be null at this location. If input.getLeft() was null, an NPE would have been raised at line 238 (final IResource resource  = ((ResourceNode) input.getLeft()).getResource();)

-------------------------------------
