DESCRIPTION

Wizard invoking automated import

Change-Id: I4e3039f1b066e245fd4e26a2b93998ed2795b7ef
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2015-03-17 10:07:00.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-03-17 10:07:06.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6840/

-------------------------------------
author: Brenden Conley
date: 2015-03-17 10:23:49.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/6840/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2015-03-17 18:54:16.000000000

Patch Set 1: Code-Review-1

Please remove .class files from review and check if .gitignore rules in the root directory need to be uodated.

Do you have filled a feature request? Please add the bug number. If not, please create one and add some description about the desired feature.

-------------------------------------
author: Jayvion Booth
date: 2015-03-17 19:04:00.000000000

Patch Set 1:

(4 comments)

Please check comments in the code.

Line:12, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> The id is odd.

Line:16, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> Trailing whitespace

Line:59, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> Haven't tried this code, but looks strange that clone operation is done in setVisible() method call (in UI thread?). Hope that rhis is not the case.

Line:92, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> Please remove TODO.

Please rwmove all the trailing spaces in the file.

-------------------------------------
author: Douglas Trujillo
date: 2015-03-18 00:06:02.000000000

Patch Set 1: Code-Review-1

(21 comments)

File Comment: incubation/org.eclipse.egit.ui.importer/bin/org/eclipse/egit/ui/internal/clone/Activator.class -> binaries should be ignored

File Comment: incubation/org.eclipse.egit.ui.importer/bin/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.class -> binaries should be ignored

Line:10, incubation/org.eclipse.egit.ui.importer/META-INF/MANIFEST.MF -> master is now on version 4.0.0

Line:1, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> missing license header

Line:9, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> could we make this an optional fragment for host bundle org.eclipse.egit.ui ?

Line:12, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> s/org.jboss.tools.playground.eaymport.egit/org.eclipse.egit.ui.importer/

Line:25, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> style nit: we don't use see tags to refer to javadoc of superclass

Line:8, /COMMIT_MSG -> add a bit more context so that others seeing this commit have a chance to find out what this is about, probably there's also some bug for the auto-import itself which could be referenced from here

File Comment: org.eclipse.egit.mylyn-feature/.settings/org.eclipse.core.resources.prefs -> why are you deleting this unrelated preference ?

Line:1, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> missing license header

Line:29, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> remove trailing whitespaces

Line:92, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> remove generated comment, if there's no implementation put

 // empty

to avoid warning

File Comment: incubation/org.eclipse.egit.ui.importer/bin/org/eclipse/egit/ui/internal/clone/EasymportGitWizard$1.class -> binaries should be ignored

File Comment: org.eclipse.egit.core/.settings/org.eclipse.core.resources.prefs -> why are you deleting this unrelated preference ?

Line:74, pom.xml -> why do we need yet another version definition here ?

Line:301, pom.xml -> remove trailing whitespace

Line:335, pom.xml -> you could use ${egit-version} instead

Line:34, org.eclipse.egit.repository/category.xml -> this is pretty fuzzy, how about "Incubating experimental auto project import" ?

Line:8, incubation/org.eclipse.egit.ui.importer/pom.xml -> why is this relative path required ?
looks like going one level up is enough

Line:12, incubation/org.eclipse.egit.ui.importer/pom.xml -> we need to adapt the scripts tools/version.sh and tools/release.sh, so far they are only capable of flipping the same version in all bundles and features.

Line:14, incubation/org.eclipse.egit.ui.importer/pom.xml -> style nit: trailing whitespace

-------------------------------------
author: Douglas Trujillo
date: 2015-03-18 00:07:01.000000000

Patch Set 1:

this change doesn't depend on "Feature to populate remote host..." so better base this on origin/master

-------------------------------------
author: Isis Velasquez
date: 2015-03-18 07:13:58.000000000

Patch Set 1:

(3 comments)

Line:9, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/Activator.java -> I don't think it's possible since both org.eclipse.egit.ui and this bundle contribute a plugin.xml.

Line:59, incubation/org.eclipse.egit.ui.importer/src/org/eclipse/egit/ui/internal/clone/EasymportGitWizard.java -> I'll try to improve that piece of code, that moreover contains a bug.

Line:8, incubation/org.eclipse.egit.ui.importer/pom.xml -> It's because I did put this bundle under an 'incubation' folder. Should I move it up along with regulat bundles?

-------------------------------------
