DESCRIPTION

Add Helpers class to egit core bundle

Adds Helpers.isNonWorkspace(IResource) for quick detecting of
non-workspace files.

Change-Id: I962d8df5f31b0b6f1197dcce5201a9c835a5386d
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2011-10-22 18:02:14.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1788/ 

-------------------------------------
author: Brenden Conley
date: 2011-10-22 18:14:49.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1788/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2011-10-28 08:47:21.000000000

Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)



Line:71, org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTree.java -> typo: s/isNonWorksapce/isNonWorkspace/

Line:84, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/action/GitOpenInCompareAction.java -> again same typo

Line:16, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> Helpers sounds a bit too generic. We already have  

 org.eclipse.egit.core.internal.util.ResourceUtil

I think your helper method should be moved there.

Line:23, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> better: Determine if given resource is imported into workspace or not

Line:29, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> typo: s/isNonWorksapce/isNonWorkspace/

-------------------------------------
author: Leslie Stephenson
date: 2011-10-28 09:38:22.000000000

Patch Set 1: (5 inline comments)



Line:71, org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTree.java -> Done

Line:84, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/action/GitOpenInCompareAction.java -> Done

Line:16, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> Done

Line:23, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> Done

Line:29, org.eclipse.egit.core/src/org/eclipse/egit/core/Helpers.java -> Done

-------------------------------------
