DESCRIPTION

Auto share projects located in a git working tree

Automatically share projects on import or creation if they are not
shared with another team provider already and if they are contained in
the working tree of an existing Git repository. Auto-sharing can be
configured with a new preference.

Bug: 356953
Change-Id: I638fc7afd155f45e392d2a74bf8c36ef2d7ad063
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2011-09-27 14:48:49.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2011-09-27 14:51:46.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1688/ 

-------------------------------------
author: Brenden Conley
date: 2011-09-27 15:03:32.000000000

Patch Set 7: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1688/ : UNSTABLE

-------------------------------------
author: Marlie Beasley
date: 2011-09-29 15:13:57.000000000

Patch Set 7: I would prefer that you didn't submit this

Exeception occurs on closing projects. Check for project.isAccessible() in resource change listener

org.eclipse.core.internal.resources.ResourceException: Resource '/aaa' is not open.
	at org.eclipse.core.internal.resources.Project.checkAccessible(Project.java:137)
	at org.eclipse.core.internal.resources.Container.members(Container.java:265)
	at org.eclipse.core.internal.resources.Container.members(Container.java:248)
	at org.eclipse.egit.core.project.RepositoryFinder.find(RepositoryFinder.java:137)
	at org.eclipse.egit.core.project.RepositoryFinder.find(RepositoryFinder.java:97)
	at org.eclipse.egit.core.Activator$AutoShareProjects$1.visit(Activator.java:233)
	at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:68)
	at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:79)
	at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:48)
	at org.eclipse.egit.core.Activator$AutoShareProjects.resourceChanged(Activator.java:206)
	at org.eclipse.core.internal.events.NotificationManager$2.run(NotificationManager.java:291)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
	at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
	at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:327)
	at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1181)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:45)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
!SUBENTRY 1 org.eclipse.core.resources 4 372

-------------------------------------
author: Marlie Beasley
date: 2011-09-29 15:40:42.000000000

Patch Set 7: (3 inline comments)



Line:249, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> why catching Throwable here?

Line:250, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> Exception does not occur.

Line:253, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> The only Exception to catch here is the IllegalArgumentException (addConfiguredRepository).
Eclipse will not break if another Exception occurs in the listener.

-------------------------------------
author: Douglas Trujillo
date: 2011-09-29 21:04:05.000000000

Patch Set 7: (3 inline comments)



Line:249, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> Done

Line:250, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> Done

Line:253, org.eclipse.egit.core/src/org/eclipse/egit/core/Activator.java -> Done

-------------------------------------
