DESCRIPTION

Implement an IndexDiff cache

The index diff cache caches the current IndexDiff for git repositories.
Clients can register listeners to receive notifications if an index
diff changes. Index diffs are updated based on index changed events
of the repository and on resource change events.

Change-Id: I3c7745e9a9a3af20374a944e615b3742ba6e5938
Signed-off-by: Marlie Beasley xxx@xxx.xxx


COMMENTS

author: Marlie Beasley
date: 2011-09-09 13:39:07.000000000

Uploaded patch set 7.

-------------------------------------
author: Marlie Beasley
date: 2011-09-09 15:56:06.000000000

Patch Set 7: No score



-------------------------------------
author: Leslie Stephenson
date: 2011-09-09 21:04:38.000000000

Patch Set 7: I would prefer that you didn't submit this

(3 inline comments)



Line:2, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/indexDiff/IndexDiffCacheTest.java -> I think you meant 2011 not 2010

Line:47, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffData.java -> personally I would prefer to have here something like this:

this(null, null, null, indexDiff);

Line:78, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffData.java -> and here instead of lines 79-87:

if (changedFileResources != null)
	this.changedFileResources = Collections
			.unmodifiableCollection(new HashSet<IFile>(changedFileResources));
else
	this.changedFileResources = null;

Set<String> added2, changed2, removed2, missing2, modified2, untracked2, conflicts2;
if (baseDiff != null) {
	added2 = new HashSet<String>(baseDiff.getAdded());
	changed2 = new HashSet<String>(baseDiff.getChanged());
	removed2 = new HashSet<String>(baseDiff.getRemoved());
	missing2 = new HashSet<String>(baseDiff.getMissing());
	modified2 = new HashSet<String>(baseDiff.getModified());
	untracked2 = new HashSet<String>(baseDiff.getUntracked());
	conflicts2 = new HashSet<String>(baseDiff.getConflicting());
} else {
	added2 = new HashSet<String>();
	changed2 = new HashSet<String>();
	removed2 = new HashSet<String>();
	missing2 = new HashSet<String>();
	modified2 = new HashSet<String>();
	untracked2 = new HashSet<String>();
	conflicts2 = new HashSet<String>();
}

-------------------------------------
author: Brenden Conley
date: 2011-09-12 20:42:20.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/1596/ 

-------------------------------------
author: Brenden Conley
date: 2011-09-12 20:53:59.000000000

Patch Set 7: I would prefer that you didn't submit this

Build Unstable 
 
https://hudson.eclipse.org/sandbox/job/egit.gerrit/1596/ : UNSTABLE

-------------------------------------
author: Marlie Beasley
date: 2011-09-21 08:42:29.000000000

Patch Set 7: (2 inline comments)



Line:2, org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/indexDiff/IndexDiffCacheTest.java -> Done

Line:78, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffData.java -> I prefer two constructors with simple coding instead of one with several ifs.

-------------------------------------
