DESCRIPTION

GitLightweightDecorator code cleanup part 1

- Made non-final fields final where possible
- Renamed constants to match Java coding guidelines
- Changed mutable final String array fields to immutable String Lists
- moved ensureFontAndColorsCreated() call at the begin in constructor
before connecting any listeners
- Display.getDefault() -> PlatformUI.getWorkbench().getDisplay()
- smaller cleanups

The code behavior is not changed.

Change-Id: Ia149409c5dd08b8d42338d9e63b09eb75a6b0056
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2015-02-11 23:51:48.000000000

Patch Set 3: Code-Review+2

-------------------------------------
author: Brenden Conley
date: 2015-02-12 00:08:13.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/581/

-------------------------------------
author: Brenden Conley
date: 2015-02-12 00:28:52.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/582/

-------------------------------------
author: Brenden Conley
date: 2015-02-12 00:44:55.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/582/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2015-02-12 09:29:12.000000000

Patch Set 3: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/583/

-------------------------------------
author: Brenden Conley
date: 2015-02-12 09:44:44.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/583/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2015-02-12 16:18:15.000000000

Patch Set 3: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/584/

-------------------------------------
author: Brenden Conley
date: 2015-02-12 16:21:53.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/584/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2015-02-12 16:31:15.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/585/

-------------------------------------
author: Brenden Conley
date: 2015-02-12 16:46:40.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/585/ : temporary update site https://hudson.eclipse.org/egit/job/egit-stable.gerrit/${BUILD_NUMBER}/artifact/org.eclipse.egit.repository/target/repository/

-------------------------------------
author: Douglas Trujillo
date: 2015-02-12 22:40:39.000000000

Change has been successfully merged into the git repository.

-------------------------------------
