DESCRIPTION

Added checkbox to commit dialog so that one can also push changes after
committing. 

Bug: 330048
Change-Id: I70156b722cd5498fddad57cdd978004b94c259ff
Signed-off-by: Brendon Russo xxx@xxx.xxx

COMMENTS

author: Alana York
date: 2011-09-01 17:17:54.000000000

Uploaded patch set 2.

-------------------------------------
author: Douglas Trujillo
date: 2011-09-01 21:26:31.000000000

Patch Set 2: I would prefer that you didn't submit this

(5 inline comments)

I think most often users want to "Push to upstream" instead of going through the full-blown push wizard.

I tried the following scenario:
- cloned a local sample repo using file:// protocol
- change a file and commit/push to the origin using refspec HEAD:refs/heads/master
- change file again and try to again commit/push
- second commit with push option fails with

!ENTRY org.eclipse.egit.ui 4 0 2011-09-01 23:20:31.550
!MESSAGE Could not execute command "org.eclipse.egit.ui.team.Push" since there's no actve handler for it
!STACK 0
org.eclipse.core.commands.ExecutionException: Could not execute command "org.eclipse.egit.ui.team.Push" since there's no actve handler for it
	at org.eclipse.egit.ui.internal.actions.CommitActionHandler.executePushCommand(CommitActionHandler.java:94)
	at org.eclipse.egit.ui.internal.actions.CommitActionHandler.execute(CommitActionHandler.java:63)
	at org.eclipse.egit.ui.internal.actions.RepositoryAction.run(RepositoryAction.java:86)
	at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4125)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1457)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1480)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1465)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1270)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3971)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3610)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Caused by: org.eclipse.core.commands.NotHandledException: There is no handler to execute for command org.eclipse.egit.ui.team.Push
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:485)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommandInContext(HandlerService.java:270)
	at org.eclipse.egit.ui.internal.utils.CommandUtils.doExecuteCommand(CommandUtils.java:79)
	at org.eclipse.egit.ui.internal.utils.CommandUtils.executeCommand(CommandUtils.java:57)
	at org.eclipse.egit.ui.internal.actions.CommitActionHandler.executePushCommand(CommitActionHandler.java:83)
	... 35 more

Line:3160, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIText.java -> style nit: extra blank in front of tab

Line:61, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java -> style nit: trailing whitespace

Line:1090, org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties -> typo: s/actve/active/

Line:7, /COMMIT_MSG -> style nit: commit header is too wide, follow recommendations in [1]

[1] http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

Line:8, /COMMIT_MSG -> style nit: trailing whitespace

-------------------------------------
