DESCRIPTION

Added checkbox to commit dialog so that one can also push
changes after committing. Changed CommitActionHandler to execute push
command.

Bug: 330048
Change-Id: I70156b722cd5498fddad57cdd978004b94c259ff
Signed-off-by: Brendon Russo xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2011-09-01 12:43:20.000000000

Patch Set 1: I would prefer that you didn't submit this

(15 inline comments)

This seams to be a great new feature! I didn't run it but it seams to be very useful.

I've added some comments regardless our code conventions and commit message conventions, please see my inline comments.

Line:125, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> this is unrelated change. please don't change code formatting

Line:130, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above, don't change code formatting of existing code in repository

Line:154, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> another unrelated code formatting change

Line:182, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> another unrelated code formatting change

Line:191, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above

Line:213, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above

Line:228, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above

Line:317, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above

Line:360, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java -> same as above

Line:61, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java -> we don't use curly brackets for single line bolocks

Line:69, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java -> same as above

Line:25, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/utils/CommandUtils.java -> we don't xxx@xxx.xxx tag, please remove this and add proper java doc for this util class

Line:48, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/utils/CommandUtils.java -> remove curly brackets

Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/utils/CommandUtils.java -> same issue with brackets as above

Line:7, /COMMIT_MSG -> Please keep with our commit message guide lines http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
