DESCRIPTION

Accept git clone command as URI

It happens regularly that I copy/paste a complete git clone command from
a website into the clone wizard instead of just the URI. This change
makes the dialog accept such input by automatically stripping the prefix
"git clone ".

Change-Id: I0baf9472a4210bca59b8a8e64148e4a61cfc1354
Signed-off-by: Jack Yu xxx@xxx.xxx


COMMENTS

author: Jack Yu
date: 2015-01-27 08:14:37.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-01-27 08:14:43.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/6667/

-------------------------------------
author: Douglas Trujillo
date: 2015-01-27 08:24:09.000000000

Patch Set 3: Code-Review-1

(2 comments)

Line:1002, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> if we do the following we can also auto-trim trailing whitespace:

 String strippedText = stripGitCloneCommand(text);
 final URIish u = new URIish(strippedText);
 if (!text.equals(strippedText))
         uriText.setText(strippedText);

Line:304, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> why should we allow whitespace in front of the URL but not at the end ? this seems inconsistent, see comment in RepositorySelectionPage

-------------------------------------
author: Brenden Conley
date: 2015-01-27 08:31:37.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/6667/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2015-03-04 14:47:00.000000000

Patch Set 3:

(2 comments)

Line:1002, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java -> Done

Line:304, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> Done

-------------------------------------
